• Jakob Kummerow's avatar
    [tests] Make processing of test filters faster · f15cb8fe
    Jakob Kummerow authored
    The test driver compares command-line arguments against test names
    it finds on disk. Using Python's "fnmatch" for this nicely handles
    wildcards, but is relatively slow. For given test names that don't
    contain any '*', we can use string equality testing, which is much
    faster.
    
    Example: the time to evaluate
    
     tools/run-tests.py --arch x64 --mode release \
       $(grep 'object-spread' -l -r test/test262/data/test/ | \
           sed -E 's|\.js$||' | \
           sed -E 's|^test/test262/data/test/|test262/|')
    
    goes from "I gave up and killed the process after several minutes"
    to a couple of seconds with this patch.
    
    Change-Id: I9ec404b7516afd801fe6126347f6dff533d1977c
    Reviewed-on: https://chromium-review.googlesource.com/1149196
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54704}
    f15cb8fe
filter.py 2.43 KB