• Ross McIlroy's avatar
    Reland "Get BytecodeArray via current frame where possible." · 3530998c
    Ross McIlroy authored
    This is a reland of 7350e7b2
    
    Disabled LayoutTest that was causing issues and will rebaseline once this has rolled.
    
    Original change's description:
    > Get BytecodeArray via current frame where possible.
    >
    > With BytecodeArray flushing the SFI->BytecodeArray pointer will become pseudo weak.
    > Instead of getting the bytecode array from the SFI, get it from the frame instead
    > (which is a strong pointer). Note: This won't actually change behaviour since the
    > fact that the bytecode array was on the frame will retain it strongly, however it
    > makes the contract that the BytecodeArray must exist at these points more explicit.
    >
    > Updates code in runtime-profiler.cc, frames.cc and runtime-test.cc to do this.
    >
    > BUG=v8:8395
    >
    > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
    > Change-Id: Id7a3e6857abd0e89bf238e9b0b01de4461df54e1
    > Reviewed-on: https://chromium-review.googlesource.com/c/1310193
    > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Mythri Alle <mythria@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#57198}
    
    TBR=mythria@chromium.org
    
    Bug: v8:8395
    Change-Id: I63044138f876a1cdfb8bb71499732a257f30d29a
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
    Reviewed-on: https://chromium-review.googlesource.com/c/1314336Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57219}
    3530998c
runtime-profiler.cc 9.15 KB