• Simon Zünd's avatar
    Remove dead code in the CommandlineAPI destructor · 4a26b54d
    Simon Zünd authored
    The CommandlineAPI destructor retrieves the property descriptors for
    every function it installed on the global object, but it doesn't do
    anything with the descriptor directly, just verifies that it could
    retrieve them.
    
    As there are cases where 'getOwnPropertyDescriptor' can actually fail,
    such as stack overflow or termination exceptions, we remove the check.
    
    R=yangguo@chromium.org
    
    Bug: chromium:914286
    Change-Id: I01147195bdf107131de602789f448abe0afa6b0e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2516470
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70939}
    4a26b54d
v8-console.cc 36.9 KB