• Peter Marshall's avatar
    [tracing] Fix TracingCpuProfiler test for Perfetto · 5ab7510e
    Peter Marshall authored
    Update the TracingCpuProfiler test to work properly with perfetto.
    
    Roll perfetto to get fixes for bugs encountered with starting/stopping
    tracing rapidly, which happens in the test for the tracing profiler.
    
    Add a check that the DataSource::Register call was successful to flush
    out any errors there (although they are fixed by the perfetto roll).
    
    Emit a fake trace event when stopping tracing in order to avoid
    losing the final trace event that the user provided. Remove the ad-hoc
    fake final trace events that the cctests for perfetto added.
    
    Add a test StartAndStopRepeated which flushes out the issues fixed by
    the perfetto roll.
    
    TBR=yangguo@chromium.org
    
    Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng
    Bug: v8:8339
    Change-Id: I042d7385486bf42c86f1631406974693868a477f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1731006
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63083}
    5ab7510e
trace-buffer.h 1.5 KB