• Camillo Bruni's avatar
    Reland "[log][d8] Only use d8.log.getAndStop on temporary log file" · 1724c77c
    Camillo Bruni authored
    This is a reland of 21bb43cc
    
    The build failures seems to be an infra flake.
    
    Original change's description:
    > [log][d8] Only use d8.log.getAndStop on temporary log file
    >
    > We run tests in parallel which can cause multiple tests to write to
    > the shared v8.log file. This obviously breaks the simple assertions in
    > mjsunit/tools/log.js.
    >
    > - Use temporary files for log testing with --logfile='+'
    >
    > - Change the symbol from '&' to '+' for using temporary files for
    >   logging with --logfile
    >
    > - Enable skipped log tests again.
    >
    > Bug: v8:10937, chromium:1129854, chromium:1130196
    > Change-Id: I607dc9a9ecc352e58525cdd21c1c93efebf0f09f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2421826
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70071}
    
    Bug: v8:10937
    Bug: chromium:1129854
    Bug: chromium:1130196
    Change-Id: I2ccf7528f35057ef668aa211142e0f1073fc1fc3
    Tbr: verwaest@chromium.org, victorgomes@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424257Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70076}
    1724c77c
log-utils.cc 8.07 KB