• Eric Leese's avatar
    V8 Wasm locations should always be based on byte offsets · 5c23e6b5
    Eric Leese authored
    Currently there are two ways wasm locations are represented in the
    inspector. This remains unchanged for now. Also, currently there are
    multiple ways location is represented within V8, with the line number
    sometimes being a function index and sometimes being 0, and the column
    number being a byte offset which is sometimes function relative and
    sometimes module relative. With this change, the line number is never
    used within V8 (it is always 0), and the column number is always a
    byte offset from the beginning of the module. This simplifies
    translation logic and keeps it in one place, and will simplify future
    changes to wasm location representation in the inspector API.
    
    Bug: chromium:1013527
    Change-Id: I8813d47c881988f9ab49d7529fb81fe10dbbccff
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1886915
    Commit-Queue: Eric Leese <leese@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64774}
    5c23e6b5
test-wasm-trap-position.cc 5.54 KB