Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Contribute to GitLab
  • Sign in / Register
V
V8
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Linshizhi
  • V8
  • Repository

Switch branch/tag
  • v8
  • test
  • mjsunit
  • harmony
  • modules-skip-1.json
Find file
BlameHistoryPermalink
  • Daniel Clark's avatar
    [modules][api] Add version of HostImportModuleDynamically with import assertions · a09c076f
    Daniel Clark authored Jan 26, 2021
    This change completes support for import assertions for dynamic import().
    
    A new version of the HostImportModuleDynamically callback taking import
    assertions is added to the public API. The name is very verbose; we
    could consider removing the "ImportAssertions" part when the old API
    is removed.
    
    Bytecode generation is updated to pass the assertions, if present, to
    Runtime_DynamicImportCall.
    
    Isolate::RunHostImportModuleDynamicallyCallback extracts the assertions
    from the options bag, filters out the assertions not present in the
    list specified by the host in HostGetSupportedImportAssertions, and
    sorts them by code point order of the keys per
    https://tc39.es/proposal-import-assertions/#sec-import-call-runtime-semantics-evaluation.
    The resulting array is passed to the host in the callback.
    
    Bug: v8:10958
    Change-Id: I931df00f954a9f9c65bff5bcf461ba1c8f11e94e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2620578
    Commit-Queue: Dan Clark <daniec@microsoft.com>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72307}
    a09c076f
modules-skip-1.json 14 Bytes
EditWeb IDE

Replace modules-skip-1.json

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.