Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Contribute to GitLab
  • Sign in / Register
V
V8
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Linshizhi
  • V8
  • Repository

Switch branch/tag
  • v8
  • test
  • inspector
  • sessions
  • runtime-evaluate-expected.txt
Find file
BlameHistoryPermalink
  • Sergiy Byelozyorov's avatar
    Revert "[inspector] RemoteObject.description should be empty for primitive type" · bbfe7f32
    Sergiy Byelozyorov authored May 31, 2018
    This reverts commit 003159e7.
    
    Reason for revert: breaks roll into Chromium: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_headless_rel/3140
    
    Original change's description:
    > [inspector] RemoteObject.description should be empty for primitive type
    > 
    > We currently report description field for numbers. On client side user
    > can calculate description as remoteObject.unserializableValue ||
    > (remoteObject.value + ''). Let's report description only for objects to
    > simplify value -> remoteObject logic a bit.
    > 
    > R=​dgozman@chromium.org
    > TBR=jgruber@chromium.org
    > 
    > Bug: chromium:595206
    > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
    > Change-Id: I91356a44aa3024e20c8f966869abf4a41b88e4bc
    > Reviewed-on: https://chromium-review.googlesource.com/737485
    > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    > Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#53453}
    
    TBR=dgozman@chromium.org,pfeldman@chromium.org,kozyatinskiy@chromium.org
    
    Change-Id: Ifc184e1ac158d9ea7034922a7250444448fac49f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:595206
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
    Reviewed-on: https://chromium-review.googlesource.com/1081207Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
    Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53461}
    bbfe7f32
runtime-evaluate-expected.txt 406 Bytes
EditWeb IDE

Replace runtime-evaluate-expected.txt

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.