• Leszek Swirski's avatar
    [offthread] Add OffThreadFactory support to AST strings · bcbb553d
    Leszek Swirski authored
    Add support for internalizing an AstValueFactory using the off-thread
    factory. Includes adding ConsString support to OffThreadFactory.
    
    This introduces a Handle union wrapper, which is used in locations that
    can store a Handle or an OffThreadHandle. This is used in this patch for
    the internalized "string" field of AST strings, and will be able to be
    used for other similar fields in other classes (e.g. the ScopeInfo
    handle in Scope, object boilerplate descriptor handles, the inferred
    name handle on FunctionLiterals, etc.). It has a Factory-templated
    getter which returns the appropriate handle for the factory, and a
    debug-only tag to make sure the right getter is used at runtime. This
    union wrapper currently decomposes implicitly to a Handle if the getter
    is not called, to minimise code changes, but this implicit conversion
    will likely be removed for clarity.
    
    Bug: chromium:1011762
    Change-Id: I5dd3a7bbdc483b66f5ff687e0079c545b636dc13
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1993971
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65816}
    bcbb553d
off-thread-factory-unittest.cc 6.42 KB