• Jakob Kummerow's avatar
    [elements.cc] Specialize CollectValuesOrEntriesImpl · 32b5cad1
    Jakob Kummerow authored
    When collecting the values of an object with Smi or Object elements
    kind, there are no allocations, so we don't need to create a short-
    lived handle for each value. This gives a small performance benefit
    in general, and in particular on ia32 by reducing register pressure
    causes clang to spill less, which fixes the regression in the issue
    mentioned below.
    
    Bug: chromium:833591
    Change-Id: I5eb0c6164b2972306ce965ec101687cab486bf0d
    Reviewed-on: https://chromium-review.googlesource.com/1029417
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52825}
    32b5cad1
elements.cc 186 KB