• Omer Katz's avatar
    Reland "cppgc: Use tracing scopes" · 2c66a0ef
    Omer Katz authored
    This reverts commit 64bf4c53.
    
    Reason for revert: fix in patchset 2
    
    Original change's description:
    > Revert "cppgc: Use tracing scopes"
    >
    > This reverts commit 548fe208.
    >
    > Reason for revert: Issues on Mac64: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac64%20-%20debug/31710
    >
    > Original change's description:
    > > cppgc: Use tracing scopes
    > >
    > > The scopes themselves mostly have the same coverage as current scopes in
    > > blink. A few exception due to encapsulation exist and are highlighted as
    > > comments on the CL.
    > >
    > > Bug: chromium:1056170
    > > Change-Id: I48af2cfdfd53a8caa1ab5d805d377f6f13a825bc
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2540552
    > > Commit-Queue: Omer Katz <omerkatz@chromium.org>
    > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#71285}
    >
    > TBR=ulan@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org
    >
    > Change-Id: I20dce9309dcaeff6ea61bdc51df3a2f62c2a103f
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: chromium:1056170
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2550782
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#71289}
    
    TBR=ulan@chromium.org,mlippautz@chromium.org,clemensb@chromium.org,omerkatz@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: chromium:1056170
    Change-Id: I9c57cdb3b0d310366cdf3e6fbcd1254fdc363163
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2550666
    Auto-Submit: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71305}
    2c66a0ef
heap-base.cc 2.96 KB