• Liviu Rau's avatar
    [test] Refactor testrunner (3) · 9733dacc
    Liviu Rau authored
    - removed some 'feature envy' instances:
      - created a AugmentedOptions class to take care of non trivial option look-ups
      - moved some calculation closer the the actual data
    - promoted parameter that was passed around a lot (options) to filed in the offending class
    - similar object creation looks a bit more similar
    - CommandContext provides a wrapper that ensures resource de-allocation
    - separate tests from standard and num_fuzz runners
    - added a couple of more tests to improve coverage
    
    This is still in flux. But further changes risk creating a disconnect between the original implementation and further refactorings.
    
    Bug: v8:12785
    Change-Id: I0ec2e9c6a81604a5cd1d4a80982dd3329c1b48db
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3686411
    Commit-Queue: Liviu Rau <liviurau@chromium.org>
    Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81148}
    9733dacc
base_runner.py 27.1 KB