• Clemens Backes's avatar
    [wasm][debug] Fix location computation from interpreted frames · 700f9b0e
    Clemens Backes authored
    The {IsWasmFrame} check in {ComputeLocationFromStackTrace} only returned
    true for compiled frames, but not for interpreted ones. Thus, for
    interpreted frames we would run into the code for JS frames, which
    assumes that a {JSFunction} is available.
    
    This CL fixes this issue by renaming {IsWasmFrame} to
    {IsWasmCompiledFrame}, and introducing a new {IsWasmFrame} method which
    returns true for both compiled and interpreted frames.
    
    R=mstarzinger@chromium.org
    
    Bug: chromium:1018227
    Change-Id: If83b4129edaad775a212ccb741f3c62eabc2addb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1883892Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64607}
    700f9b0e
messages.cc 49.5 KB