• mattloring's avatar
    Reland of Include file names in trace_turbo output (patchset #1 id:1 of... · 9480ea44
    mattloring authored
    Reland of Include file names in trace_turbo output (patchset #1 id:1 of https://codereview.chromium.org/2083153004/ )
    
    Reason for revert:
    Ready to test fix and reland.
    
    Original issue's description:
    > Revert of Include file names in trace_turbo output (patchset #3 id:40001 of https://codereview.chromium.org/2083863004/ )
    >
    > Reason for revert:
    > Many build bots are failing with a message of the form:
    >
    > Missing or invalid v8 JSON file: /tmp/tmp2qcEUy_swarming/0/output.json
    >
    > Can be relanded once we understand why these failures are occuring.
    >
    > Original issue's description:
    > > Include file names in trace_turbo output
    > >
    > > The trace turbo output will overwrite itself when functions in different
    > > files share the same name. Output files now have the form
    > > `turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`.
    > >
    > > R=ofrobots@google.com
    > > BUG=
    > >
    > > Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba
    > > Cr-Commit-Position: refs/heads/master@{#37199}
    >
    > TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org
    > # Skipping CQ checks because original CL landed less than 1 days ago.
    > NOPRESUBMIT=true
    > NOTREECHECKS=true
    > NOTRY=true
    > BUG=
    >
    > Committed: https://crrev.com/97c2bc362f234bd58515a0faf6af23b4f8ad183a
    > Cr-Commit-Position: refs/heads/master@{#37204}
    
    TBR=ofrobots@google.com,bmeurer@chromium.org,danno@chromium.org,machenbach@google.com
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=
    
    Review-Url: https://codereview.chromium.org/2081323007
    Cr-Commit-Position: refs/heads/master@{#37303}
    9480ea44
graph-visualizer.cc 21.1 KB