• Michael Starzinger's avatar
    Revert "[wasm] Improve module code size sampling approach." · 9665e4ce
    Michael Starzinger authored
    This reverts commit 0f2d22dd.
    
    Reason for revert: Caused a race discovered by TSAN.
    
    Original change's description:
    > [wasm] Improve module code size sampling approach.
    > 
    > This samples module code sizes at GC time instead of during destruction.
    > It hence makes sure that we also receive samples for long-lived modules
    > which would otherwise die with the Isolate and never be finalized. Note
    > that this approach is still biased and just a stop-gap until we have a
    > sampling tick based on actual wall-clock time.
    > 
    > R=​clemensh@chromium.org
    > 
    > Change-Id: I9558d383a5aada8876bc9cbf63baca771dbe5c28
    > Reviewed-on: https://chromium-review.googlesource.com/1141866
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#54554}
    
    TBR=ulan@chromium.org,mstarzinger@chromium.org,clemensh@chromium.org
    
    Change-Id: Ie1fc99ad0ef36b30a73cc464808ce7679a0f15df
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/1143284Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54557}
    9665e4ce
isolate.cc 148 KB