• Leszek Swirski's avatar
    [isolate] Revert oddball checks to non-const Isolate* · 29af4273
    Leszek Swirski authored
    Looks like even the small amount of logic needed to extract ReadOnlyRoots
    from a const Isolate* (e.g. a HeapObject check) is enough to cause
    regressions.
    
    Revert these predicates to take non-const Isolate*, while keeping const
    Isolate* elsewhere. If we ever need const Isolate* for the oddball
    predicates, we can add it in addition to the non-const one.
    
    Bug: chromium:1029457
    Bug: chromium:1030001
    Bug: chromium:1030003
    Bug: chromium:1030102
    Change-Id: Ia6fa45f282a1a1961c0afa8ed973baebf6fbafd3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948721Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65331}
    29af4273
api-callbacks.h 5.66 KB