• Jakob Kummerow's avatar
    [DataView] Throw TypeError when buffer is detached · 4534e8cc
    Jakob Kummerow authored
    Per spec, accesses to a DataView object must throw a TypeError if
    the underlying ArrayBuffer has been detached/neutered. Since that
    implies a length of 0, we used to detect this as an out-of-bounds
    access and throw a RangeError. Adding a separate check for buffer
    detachedness lets us distinguish both cases properly.
    
    Bug: v8:4895
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Change-Id: I1c1d4145dcd77dfb69f61062e14a6e8e538d45eb
    Reviewed-on: https://chromium-review.googlesource.com/947585Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51712}
    4534e8cc
builtins-dataview.cc 15 KB