• Clemens Backes's avatar
    Revert "[wasm] Do memory.copy bounds check in C++ code" · b8eeb071
    Clemens Backes authored
    This reverts commit c475e704.
    
    Reason for revert: Fails on MSVC: https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20-%20msvc/12805
    
    Original change's description:
    > [wasm] Do memory.copy bounds check in C++ code
    > 
    > In the existing implementation we first did a bounds check in generated
    > code, and then called a simple C++ function to do the actual copying.
    > With this CL now we pass the WasmInstanceObject to the C++ function in
    > addition to the memory.copy parameters. Thereby we can do the bounds
    > check in C++, which is much easier, less error prone, and which also
    > speeds up code generation and reduces code size. Performance should not
    > be worse, because we were already doing the call to C++ anyways.
    > 
    > R=​clemensb@chromium.org
    > 
    > Bug: v8:10281
    > Change-Id: I24488d92056f0b5df27a61783a274895bd37cc24
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093434
    > Commit-Queue: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#66655}
    
    TBR=ahaas@chromium.org,clemensb@chromium.org
    
    Change-Id: Ic2491f635a292e004f6c95498a045ba102138dc5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10281
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2096623
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66658}
    b8eeb071
wasm-external-refs.cc 15.1 KB