• bradnelson's avatar
    Make typing-asm match spec more closely around load/store, add more tests. · cf5546ba
    bradnelson authored
    Shifts of integer values are in some contexts collapsed by the parser into single literal AST nodes, rather than a direct representation of the parse tree. Confirming this behavior in tests.
    
    Integer TypedArrays are assumed to load and store "intish" values rather than more fine-grained type information. Reducing the precision of the typing information to match the spec and simplify the wasm generator.
    
    The asm spec requires load and store values of various "float?", "floatish", "double?" and "intish" types to ensure undefined values are not visible and that float32 rounding occurs at the right time. More closely matching this.
    
    Adding additional testing around unsigned / signed comparisons, loads and stores.
    
    Adding addition debug mode printing when asserting about types fail.
    
    BUG= https://code.google.com/p/v8/issues/detail?id=4203
    TEST=test-asm-validator, wasm side tests
    R=titzer@chromium.org,aseemgarg@chromium.org
    LOG=N
    
    Review URL: https://codereview.chromium.org/1471073003
    
    Cr-Commit-Position: refs/heads/master@{#32419}
    cf5546ba
expression-type-collector-macros.h 2.26 KB