• Eric Holk's avatar
    Restrict range for int64_t to immediate conversions · ec772a4f
    Eric Holk authored
    The included test case illustrates the problem. It subtracts (16 << 27)
    from another number. The Machine Operator Reducer would replace the
    shift computation with 0x0000000080000000, and then change the subtract
    to an add of -(0x0000000080000000), which is 0xffffffff80000000.
    The instruction selector would determine that this value could be an
    immediate, because it fits in 32 bits, so it would select the lea
    instruction. Finally, the code generator would detect that the
    immediate was less than 0, flip the sign and replace the add with a
    subtract of 0x80000000. Because the x64 subtract instruction's
    immediate field is 32 bits, the processor would interpret this as
    0xffffffff80000000 instead of an unsigned value.
    
    This change fixes the issue by making the CanBeImmediate check
    explicitly compare against INT_MIN and INT_MAX. We disallow INT_MIN
    as an immediate precisely because we cannot tell 0x0000000080000000
    from 0xffffffff80000000 when truncated to 32 bits.
    
    Bug: chromium:711203
    Change-Id: Ie371b8ea290684a6bb723bae9c693a866f961850
    Reviewed-on: https://chromium-review.googlesource.com/482448
    Commit-Queue: Eric Holk <eholk@chromium.org>
    Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#44758}
    ec772a4f
instruction-selector-x64.cc 92.6 KB