• Michael Hablich's avatar
    Revert "[snapshot] Move builtins to dedicated snapshot area" · a588411e
    Michael Hablich authored
    This reverts commit 49e3bfd5.
    
    Reason for revert: Primary suspect for blocked roll: 759552
    
    Original change's description:
    > [snapshot] Move builtins to dedicated snapshot area
    > 
    > As a first step towards lazy builtin deserialization, this CL moves
    > builtins to their own dedicated area in the snapshot blob, physically
    > located after startup data and before context-specific data.
    > 
    > The startup- and partial serializers now serialize all seen builtins as
    > references, i.e. they only encode the relevant builtin id (taking care
    > to preserve special behavior around the interpreter trampoline and
    > CompileLazy). Builtins are later fully serialized by the
    > BuiltinSerializer. The separate blobs are finally glued together by
    > CreateSnapshotBlob.
    > 
    > Deserialization takes the same steps: when we see builtin reference
    > bytecodes before builtins have been deserialized, we push to a list of
    > deferred builtin references. After builtin deserialization, this list is
    > iterated and all builtin references are fixed up.
    > 
    > Bug: v8:6624
    > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    > Change-Id: Idee42fa9c92bdbe8d5b8c4b8bf3ca9dd39634004
    > Reviewed-on: https://chromium-review.googlesource.com/610225
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#47596}
    
    TBR=yangguo@chromium.org,mlippautz@chromium.org,jgruber@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:6624
    Change-Id: I9906c9ea15a623226b890f63bc65876a6f5203f8
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/638331Reviewed-by: 's avatarMichael Hablich <hablich@chromium.org>
    Commit-Queue: Michael Hablich <hablich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47648}
    a588411e
snapshot.h 4.33 KB