• Jakob Gruber's avatar
    [nci] Replace CompilationTarget with a new Code::Kind value · c51041f4
    Jakob Gruber authored
    With the new Turbofan variants (NCI and Turboprop), we need a way to
    distinguish between them both during and after compilation. We
    initially introduced CompilationTarget to track the variant during
    compilation, but decided to reuse the code kind as the canonical spot to
    store this information instead.
    
    Why? Because it is an established mechanism, already available in most
    of the necessary spots (inside the pipeline, on Code objects, in
    profiling traces).
    
    This CL removes CompilationTarget and adds a new
    NATIVE_CONTEXT_INDEPENDENT kind, plus helper functions to determine
    various things about a given code kind (e.g.: does this code kind
    deopt?).
    
    As a (very large) drive-by, refactor both Code::Kind and
    AbstractCode::Kind into a new CodeKind enum class.
    
    Bug: v8:8888
    Change-Id: Ie858b9a53311b0731630be35cf5cd108dee95b39
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2336793
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69244}
    c51041f4
code.cc 39 KB