• Sigurd Schneider's avatar
    Revert "[ignition] Skip binding dead labels" · 8ee20f5e
    Sigurd Schneider authored
    This reverts commit 35269f77.
    
    Reason for revert: Fuzzer unhappy: https://ci.chromium.org/p/v8/builders/ci/V8%20Fuzzer/29792
    
    Original change's description:
    > [ignition] Skip binding dead labels
    > 
    > BytecodeLabels for forward jumps may create a dead basic block if their
    > corresponding jump was elided (due to it dead code elimination). We can
    > avoid generating such dead basic blocks by skipping the label bind when
    > no corresponding jump has been observed. This works because all jumps
    > except JumpLoop are forward jumps, so we only have to special case one
    > Bind for loop headers to bind unconditionally.
    > 
    > Since Binds are now conditional on a jump existing, we can no longer rely
    > on using Bind to get the current offset (e.g. at the beginning of a try
    > block). Instead, we now expose the current offset in the bytecode array
    > writer. Conveniently, this means that we can be a bit smarter about basic
    > blocks around these statements.
    > 
    > As a drive-by, remove the unused Bind(target,label) function.
    > 
    > Bug: chromium:934166
    > Change-Id: I532aa452fb083560d07b90da99caca0b1d082aa3
    > Reviewed-on: https://chromium-review.googlesource.com/c/1488763
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#59942}
    
    TBR=rmcilroy@chromium.org,leszeks@chromium.org
    
    Change-Id: I8118e54e0afa5e08b0a0a874c952f8a01f1c3242
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:934166
    Reviewed-on: https://chromium-review.googlesource.com/c/1494534Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59947}
    8ee20f5e
bytecode-array-builder.cc 52.4 KB