• Clemens Backes's avatar
    Revert "[wasm][debug] Cache debugging code" · 685f2596
    Clemens Backes authored
    This reverts commit fab754ff.
    
    Reason for revert: TSan failures: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20isolates/13875/overview
    
    Original change's description:
    > [wasm][debug] Cache debugging code
    >
    > This adds a little cache for debugging code, including stepping code.
    > Especially in stepping, we are currently repeatedly recompiling the same
    > function, because whenever we pause (after every step) we clear
    > stepping, only to reinstantiate it if the user continues stepping.
    > Especially in source-level stepping this is wasteful, because stepping
    > over a single line of C++ code can execute hundreds or thousands of
    > steps in wasm.
    >
    > R=​thibaudm@chromium.org
    >
    > Bug: chromium:1172299
    > Change-Id: Id59a26cc67a5bf4a2d3cf6b1e8f14a8b1c73712c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2732015
    > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73162}
    
    Bug: chromium:1172299
    Change-Id: I8fac7701e6f58012c8e17322c22f29692ee8932b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2732020
    Auto-Submit: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#73168}
    685f2596
wasm-debug.cc 44.1 KB