• Erik Luo's avatar
    [debug] expose SideEffectType for whitelisting embedder callbacks · 6da12d42
    Erik Luo authored
    This exposes new flags to allow embedders to whitelist callbacks as
    side-effect-free during evaluation with throwOnSideEffect.
    
    Accessors and Functions/FunctionTemplates can take a new param on:
    - v8::Object::SetNativeDataProperty
    - v8::Object::SetLazyDataProperty
    - v8::Object::SetAccessor
    - v8::FunctionTemplate::New
    - v8::FunctionTemplate::NewWithCache
    - v8::Function::New
    
    While Interceptors can be created with an additional flag:
    PropertyHandlerFlag::kHasNoSideEffect
    
    Bug: v8:7515
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: I14823316bdd6de6d362a1104b65f13504d0db056
    Reviewed-on: https://chromium-review.googlesource.com/994550
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52367}
    6da12d42
test-api-interceptors.cc 186 KB