• Seth Brenith's avatar
    Reland "Allow lookup of matching scripts in Isolate compilation cache" · 8742d2a2
    Seth Brenith authored
    This is a reland of commit c443858f
    
    The original version included an operation which could left-shift
    signed values, which is undefined behavior; the updated version masks
    the value first to avoid the problem.
    
    Original change's description:
    > Allow lookup of matching scripts in Isolate compilation cache
    >
    > Currently, if the same script text is compiled multiple times with
    > differing details (such as name, line number, or host-defined options),
    > then multiple copies of that script are added to the Isolate's
    > compilation cache. However, any attempt to look up those scripts can
    > find only the first instance. This change makes the script compilation
    > cache behave more consistently by checking the details while searching
    > the hash table for a match, rather than after a potential match has been
    > found.
    >
    > Bug: v8:12808
    > Change-Id: Ic9da0bf74f359d4f1c88af89d585404f173056ee
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3671615
    > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/main@{#80919}
    
    Bug: v8:12808
    Change-Id: I494c3c9cc520b79f34247aab6618c40c854b9edc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687070Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#81007}
    8742d2a2
compilation-cache-table.cc 19.2 KB