• Camillo Bruni's avatar
    Revert "[codegen] Disable host-defined options checks in cache" · 48ed752a
    Camillo Bruni authored
    This reverts commit 810d34df.
    
    Reason for revert: The stricter host checks prevent
    certain security issues. We will have to live with regressions
    until we have a more flexible caching solution in place.
    
    Original change's description:
    > [codegen] Disable host-defined options checks in cache
    >
    > We see too many regressions for now in M94 (~10% more misses in
    > some cases).
    >
    > This CL reverts the logic to the state before landing
    > https://crrev.com/c/3069152 without having to revert the several
    > refactoring CLs that landed on top of it.
    >
    > Bug: v8:10284, chromium:1238312, chromium:1237242
    > Change-Id: I57e66b9e0d58c36d2f1563b07720e3729c88ec94
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3103006
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#76362}
    
    Bug: v8:10284, chromium:1238312, chromium:1237242
    Change-Id: I4c662dd0ac16a4406f06fb2a62b9e4e65fa428ce
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114057
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76504}
    48ed752a
compilation-cache.cc 14.5 KB