• Leszek Swirski's avatar
    Revert "[frames] Make interpreted frame detection stricter" · 8b5fe28c
    Leszek Swirski authored
    This reverts commit f577b2bb.
    
    Reason for revert: Failure on https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20verify%20csa/builds/1978
    
    Original change's description:
    > [frames] Make interpreted frame detection stricter
    > 
    > When iterating over stack frames, make the interpreted frame detection
    > require that the frame header contains the bytecode array.
    > 
    > Currently, the stack frame iterator supports bytecode handlers that
    > don't create stack frames by checking if the top of the stack (i.e. the
    > return address) is the interpreter entry trampoline. However, optimized
    > code tail called from the interpreter entry trampoline can move the
    > stack pointer without clearing the stack, which means it can end up with
    > a pointer into the interpreter entry trampoline on the top of its stack
    > (in an uninitialized value), and be interpreted as an interpreted frame.
    > 
    > To avoid such optimized code frames being interpreted as interpreted
    > frames, we now additionally test the frame header, to see if it contains
    > a BytecodeArray.
    > 
    > Change-Id: I4bafcf0f7ce3c973a2e5a312f054d72312bb8a70
    > Reviewed-on: https://chromium-review.googlesource.com/535646
    > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#45951}
    
    TBR=kozyatinskiy@chromium.org,leszeks@chromium.org
    
    Change-Id: Icc009cf97b816f6c33574782ed9ab473387886c9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/535478Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45954}
    8b5fe28c
frames.cc 78.3 KB