• Milad Farazmand's avatar
    Revert "s390: [arm] Add missing RELATIVE_CODE_TARGET iteration" · b5939c75
    Milad Farazmand authored
    This reverts commit 9d3cca1c.
    
    Reason for revert: Only the test needs to be skipped on s390. Refer to this: https://crrev.com/c/1981505
    
    Original change's description:
    > s390: [arm] Add missing RELATIVE_CODE_TARGET iteration
    > 
    > Port b766299d
    > Port 9592b043
    > Port d915b8d6
    > 
    > Original Commit Message:
    > 
    >     Code object iteration was missing logic for RELATIVE_CODE_TARGET
    >     reloc entries. Garbage collection could thus miss objects that were
    >     referenced only as targets of pc-relative calls or jumps.
    > 
    >     RELATIVE_CODE_TARGETs are only used on arm, mips, and s390 and only
    >     at mksnapshot-time.
    > 
    >     This exposed another issue in that the interpreter entry trampoline
    >     copy we generate for profiling *did* contain relative calls in
    >     runtime-accessible code. This is a problem, since code space on arm is,
    >     by default, too large to be fully addressable through pc-relative
    >     calls. This CL thus also disables the related
    >     FLAG_interpreted_frames_native_stack feature on arm.
    > 
    >     objects.
    > 
    > R=​jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
    > BUG=
    > LOG=N
    > 
    > Change-Id: Ifbcaed98d90a2730f0d6a8a7d32c621dab1ff5b2
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2087693
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
    > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    > Cr-Commit-Position: refs/heads/master@{#66644}
    
    TBR=michael_dawson@ca.ibm.com,mlippautz@chromium.org,jyan@ca.ibm.com,jgruber@chromium.org,joransiu@ca.ibm.com,miladfar@ca.ibm.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: Id645a9def23d278235ff77f25249d2187e8105ca
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196521Reviewed-by: 's avatarMilad Farazmand <miladfar@ca.ibm.com>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#67751}
    b5939c75
isolate.cc 163 KB