• Jakob Gruber's avatar
    Revert "[nci] Add Construct_WithFeedback builtin" · fe3e17d4
    Jakob Gruber authored
    This reverts commit 69f42d40.
    
    Reason for revert: The last PS introduced a bug https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20fyi/15897.
    
    Original change's description:
    > [nci] Add Construct_WithFeedback builtin
    > 
    > This builtin essentially acts like InterpreterAssembler::Construct. It
    > collects full feedback, then tail-calls either the array constructor
    > or the construct builtin.
    > 
    > For now, it is only used in generic lowering, if the --turbo-nci flag
    > is passed. One of the next steps will be to measure performance impact
    > of feedback collection. If minimal, we may want to enable it
    > unconditionally in generic lowering.
    > 
    > Bug: v8:8888
    > Change-Id: I8a460a2b5954c26fa72658045a8423c5eee6b611
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2198775
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67850}
    
    TBR=neis@chromium.org,jgruber@chromium.org,tebbi@chromium.org
    
    Change-Id: I3af168373978d773385b9eda9bc1e243e3cbea09
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8888
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2206737Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67860}
    fe3e17d4
js-generic-lowering.cc 38.8 KB