• Alexey Kozyatinskiy's avatar
    [inspector] reworked async stack instrumentation for async functions · b6c9086c
    Alexey Kozyatinskiy authored
    New intstrumentation consists of:
    - kAsyncFunctionSuspended when async function is suspended on await
      (called on each await),
    - kAsyncFunctionFinished when async function is finished.
    
    Old instrumentation was based on reusing async function promise.
    Using this promise produces couple side effects:
    - for any promise instrumentation we first need to check if it is
      special case for async function promise or not - it requires
      expensive reading from promise object.
    - we capture stack for async functions even if it does not contain
      awaits.
    - we do not properly cancel async task created for async function.
    
    New intsrumntation resolved all these problems as well as provide
    clear mapping between async task and generator which we can use later
    to fetch scope information for async functions on pause.
    
    R=dgozman@chromium.org,yangguo@chromium.org
    
    Bug: v8:7078
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ifdcec947d91e6e3d4d5f9029bc080a19b8e23d41
    Reviewed-on: https://chromium-review.googlesource.com/1043096Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53445}
    b6c9086c
builtins-async-gen.cc 8.6 KB