• Michael Achenbach's avatar
    Revert "[inspector] moved var initialization break location before init expression" · ee1db48c
    Michael Achenbach authored
    This reverts commit 7a9cc704.
    
    Reason for revert: Changes layout tests:
    https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/15882
    
    This is about:
    inspector/sources/debugger/source-frame-inline-breakpoint-decorations.html
    
    Original change's description:
    > [inspector] moved var initialization break location before init expression
    > 
    > This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position.
    > Benefits (see test for details):
    > - only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2),
    > - removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}.
    > 
    > Bug: v8:5909
    > Change-Id: I039d911903a2826c9859710a63ab0462c992e11b
    > Reviewed-on: https://chromium-review.googlesource.com/513926
    > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    > Reviewed-by: Marja Hölttä <marja@chromium.org>
    > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#45530}
    
    TBR=dgozman@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org
    # Not skipping CQ checks because original CL landed > 1 day ago.
    Bug: v8:5909
    
    Change-Id: Ibf84401e8050d3c84db219d983de2c6bba0f697f
    Reviewed-on: https://chromium-review.googlesource.com/518102Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45547}
    ee1db48c
for-of-loops-expected.txt 9.09 KB