• bmeurer's avatar
    [compiler] Always pass closure argument to with, catch and block context creation. · d3e5db04
    bmeurer authored
    Up until now we sometimes pass Smi 0 around as closure and expect the
    runtime to translate that appropriately. But we need to be careful in
    some places to not confuse the Smi 0 with a real closure. However, we
    could instead just pass the correct closure extracted from the native
    context.
    
    This addresses three long-standing TODOs in the JSTypedLowering pass.
    
    Drive-by-fix: Further unify error message reporting for ToObject (we had
    a special message in case of ToObject error in with context creation).
    
    R=yangguo@chromium.org
    
    Review URL: https://codereview.chromium.org/1475383002
    
    Cr-Commit-Position: refs/heads/master@{#32336}
    d3e5db04
messages.js 11.4 KB