• zhengxing.li's avatar
    X87: [turbofan] CodeGenerator: Frame setup refactoring. · 7e88aa3d
    zhengxing.li authored
      port 81a1530e (r35642)
    
      original commit message:
      Before frame elision, we finalized the frame shape when assembling the
      prologue, which is also when we prepared the frame (saving sp, etc).
    
      The frame finalization only needs to happen once, and happens to be
      actually a set of idempotent operations. With frame elision, the logic for
      frame finalization was happening every time we constructed the frame.
      Albeit idempotent operations, the code would become hard to maintain.
    
      This change separates frame shape finalization from frame
      construction. When constructing the CodeGenerator, we finalize the
      frame. Subsequent access is to a const Frame*.
    
      Also renamed AssemblePrologue to AssembleConstructFrame, as
      suggested in the frame elision CR.
    
      Separating frame setup gave the opportunity to do away with
      architecture-independent frame aligning (which is something just arm64
      cares about), and also with stack pointer setup (also arm64). Both of
      these happen now at frame finalization on arm64.
    
      additional message:
      This CL also removed the temporary workaround for CL #35139 (53d51c52)
    
    BUG=
    
    Review URL: https://codereview.chromium.org/1900213004
    
    Cr-Commit-Position: refs/heads/master@{#35648}
    7e88aa3d
code-generator-x87.cc 82.5 KB