• Dominik Inführ's avatar
    Revert "[heap] Add safepoints in Heap GC methods" · 850739bb
    Dominik Inführ authored
    This reverts commit 1742d256.
    
    Reason for revert: Longer safepoint can cause deadlocks with global handles.
    
    Original change's description:
    > [heap] Add safepoints in Heap GC methods
    > 
    > Add safepoints to GC methods in Heap. There is still stuff in
    > Heap::CollectGarbage which might work better or more precise in a global
    > safepoint. Be conservative here and move everything into the safepoint,
    > eventually we can start to move code out that is fine to run outside
    > the safepoint.
    > 
    > Bug: v8:10315
    > Change-Id: I656dfd72f032eff6f386cec63a02777506650aa7
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335192
    > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#69228}
    
    TBR=ulan@chromium.org,dinfuehr@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:10315
    Change-Id: Idaf575911b34674c16d46b41c2ebee9f56dbac6d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339617Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69261}
    850739bb
heap.cc 240 KB