• Andreas Haas's avatar
    [wasm][liftoff] Change size of references on stack to kSystemPointerSize · 83095e9a
    Andreas Haas authored
    With pointer compression, the size of a reference depends on whether it
    is stored on the stack or on the heap. The size provided by
    ValueType::element_size_bytes() is the size of a reference on the heap.
    LiftoffAssembler::SlotSizeForType(...) however should return the size
    on the stack. This CL fixes this inconsistency.
    
    This issue would have been found by an existing test, but this test is
    disabled at the moment because of missing safepoint maps for stack
    checks.
    
    R=thibaudm@chromium.org
    
    Bug: v8:7581
    Change-Id: Ia45944b265fa4ce0d560ff00a24b023d6c1ae10a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2552515Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71320}
    83095e9a
liftoff-assembler-ia32.h 166 KB