• Tobias Tebbi's avatar
    Revert "Extend GetIterator bytecode to perform JSReceiver check on object[Symbol.iterator]()" · 4671cb56
    Tobias Tebbi authored
    This reverts commit 91e3243d.
    
    Reason for revert: This deopts to the wrong point.
    
    Original change's description:
    > Extend GetIterator bytecode to perform JSReceiver check on object[Symbol.iterator]()
    > 
    > Current GetIterator bytecode loads and calls @@iterator property on a
    > given object. This change extends the bytecode functionality to check
    > whether the value returned after calling @@iterator property is a valid
    > JSReceiver. The bytecode throws SymbolIteratorInvalid exception if the
    > returned value is not a valid JSReceiver. This change absorbs the
    > functionality of additional two bytecodes - JumpIfJSReceiver and
    > CallRuntime, that are part of the iterator protocol in the GetIterator
    > bytecode.
    > 
    > Bug: v8:9489
    > Change-Id: I9e84cfe85eeb9a1b8a97ca0595375ac26ba1bbfd
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792905
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com>
    > Cr-Commit-Position: refs/heads/master@{#63704}
    
    TBR=rmcilroy@chromium.org,leszeks@chromium.org,tebbi@chromium.org,swapnilgaikwad@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:9489
    Change-Id: I9324b5b01ead29912ad793a1e7b4d009643d7901
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1960288Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65541}
    4671cb56
interpreter-generator.cc 121 KB