• Bruce Dawson's avatar
    Show failure codes in run.py · cad1845a
    Bruce Dawson authored
    If mksnapshot fails then all that is printed is
        "FAILED: gen/v8/embedded.S snapshot_blob.bin"
    and the command line. That complicates the investigation. Printing the
    error code in run.py can help. The printing code handles large negative
    numbers specially so that special Windows failure codes like 0xC0000005
    are recognizable.
    
    This code was tested by adding this early-out to main in mksnapshot.cc.
    
      if (argc < 1000)
        return 0xc0000005;
    
    Bug: Chromium:1095767
    Change-Id: I5dc81d368beaa339f0c519ce1c01bd13cdb18d93
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249518
    Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarJochen Eisinger <jochen@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68395}
    cad1845a
run.py 718 Bytes