-
Milad Fa authored
Wasm values are stored in memory in little endian order even on BE machines and as a result they need to be manually reversed after a load. Other such atomic ops get patched during Wasm compilation or during code-gen, this is one of the few places where a runtime call is made to C++ which requires this fix. As the the runtime stub is used on both TurboFan and Liftoff this patch will fix both cases. Up until now the cctest was passing incorrectly as it's mixing the Wasm memory buffer with TypedArrays. TypedArrays don't have the LE enforcement and use the native byte order. With this patch the test is now failing as expected and is being skipped for now. Bug: v8:12505 Change-Id: I49fac208f1fab7396b7d9911e803bc047b3b8263 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350744Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#78433}
183a2abc