• Clemens Backes's avatar
    [liftoff] Fix >=2GB memory accesses on 32-bit · 7ad5b961
    Clemens Backes authored
    We were inconsistent in handling offsets >= 2GB on 32-bit systems. The
    code was still relying on this being detected as statically out of
    bounds, but with the increase of {kV8MaxWasmMemoryPages} to support 4GB
    memories, this is not the case any more.
    
    This CL fixes this by again detecting such situations as statically OOB.
    We do not expect to be able to allocate memories of size >2GB on such
    systems. If this assumptions turns out to be wrong, we will erroneously
    trap. If that happens, we will have to explicitly disallow memories of
    such size on 32-bit systems.
    
    R=jkummerow@chromium.org
    
    Bug: v8:7881, chromium:1201340
    Change-Id: Ic89a67d38fb860eb8a48a4ff51bc02c53f8a2c2a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2848467Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74175}
    7ad5b961
compilation-environment.h 5.51 KB