• Manos Koukoutos's avatar
    [wasm-gc] Refactor type checks in wasm-compiler · 1ad3d77c
    Manos Koukoutos authored
    ref.test, ref.cast, and br_on_cast instructions all need to type check
    a value against an rtt. With new classification functions on the
    horizon, the wasm-compiler code needed to be refactored to avoid
    excessive code duplication.
    This CL factors out a function TypeCheck that takes as arguments a set
    of three callbacks functions: a conditional success, a conditional
    failure, and a negated conditional failure. Each of RefTest, RefCast,
    and BrOnCast call TypeCheck with a different set of callbacks.
    
    Bug: v8:7748
    Change-Id: I1dd8893fc26d5b0228f85587c9250706d0ce16cf
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2647262
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72362}
    1ad3d77c
wasm-compiler.cc 327 KB