• Clemens Hammacher's avatar
    [wasm] Add counter for number of code spaces · 618e290d
    Clemens Hammacher authored
    Some architectures allow more than one code space to be reserved per
    module. The strategy to allocate additional spaces seems suboptimal: We
    allocate just enough for the one code allocation request which does not
    fit in the existing space. This can lead to big numbers of reservations
    being made.
    Also, for lifting the 128MB code space limit on arm64, we will allocate
    several code spaces also on x64 and arm64.
    This CL introduces a new counter to measure the number of code spaces
    per module, to see whether we have problems there already, and to track
    that metric when implementing the mentioned change.
    
    In order to update the respective counter, the {WasmCodeAllocator} now
    also holds a shared pointer to the counters of the original isolate.
    Those counters might live much longer than the isolate itself, which is
    no problem and can already happen before this change.
    
    R=mstarzinger@chromium.org
    CC=jwd@chromium.org
    
    Bug: v8:9477
    Change-Id: I95e29b2d27f0414586246e2fa99d6761960a636b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1704100
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62767}
    618e290d
wasm-code-manager.cc 61.7 KB