• Simon Zünd's avatar
    Reland "[inspector] Allow Debugger.setScriptSource to edit top-most function" · 21fe5e0f
    Simon Zünd authored
    This is a reland of commit dac61556
    
    This is a straight-up reland with no changes, because:
      1) The failure doesn't reproduce locally
      2) The failing flaky test that triggered the revert is not related
         to the code modified by this CL and should (in theory) not be
         impacted.
    
    Original change's description:
    > [inspector] Allow Debugger.setScriptSource to edit top-most function
    >
    > This CL adds a new boolean flag on the Debugger.setScriptSource CDP
    > method that gets piped all the way through to the live-edit mechanism.
    > The new flag enables live-editing of the top-most function while
    > paused.
    >
    > The CL adds a couple of tests that cover the new core use cases for
    > this flag.
    >
    > R=jarin@chromium.org
    >
    > Bug: chromium:1334484
    > Change-Id: I12fec591b2b6550d89748714620e629548e1b9c1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695354
    > Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
    > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#81127}
    
    Bug: chromium:1334484
    Change-Id: I9a9bf7e03d81c86adb4819b9756dd9afcf6fa021
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3706398Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81171}
    21fe5e0f
v8-debugger-script.cc 12.2 KB