• Clemens Backes's avatar
    [codegen] Simplify definition of signatures · d38f84ac
    Clemens Backes authored
    Liftoff defines many signatures of fixed size. This is currently done by
    defining a fixed-size array on the stack, and then using this in the
    signature definition. This is cumbersome and hard to read, since the
    array contains return types and parameter types, and only the signature
    definition separates the two. But also the order of those two sizes in
    the signature is non-obvious and easy to get wrong.
    
    This CL introduces a helper to define fixed-size signatures in a
    "builder style", i.e. parameters and return types can be added
    separately. The fixed-size array will be contained in the returned
    class, so it will still be stack-allocated like before. The copies to
    iteratively build up this array should be completely eliminated by the
    compiler, so the binary code should look exactly the same.
    
    R=ahaas@chromium.org
    
    Bug: v8:11384
    Change-Id: I167830d6c3429f535b7d1241920730498a9bb4c1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2747505
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73341}
    d38f84ac
liftoff-compiler.cc 247 KB