• Adam Klein's avatar
    Revert "[destructuring] Elide coercible check for simple keys" · 28fa4cb4
    Adam Klein authored
    This reverts commit 1fba0441.
    
    Reason for revert: blocks V8 roll due to layout test failures caused by error message changes:
    https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux/347
    
    Original change's description:
    > [destructuring] Elide coercible check for simple keys
    > 
    > Simple object destructuring, such as `let {a,b} = o`, is less efficient
    > than the equivalent assignments `let a = o.a; let b = o.b`. This is
    > because it does a nil check of `o` before the assignments. However, this
    > nil check is not strictly necessary for simple (i.e. non-computed) names,
    > as there will be an equivalent nil check on the first access to o in
    > `o.a`. For computed names the computation is unfortunately obervable.
    > 
    > So, we can elide the nil check when the first property (if any) of the
    > destructuring target is a non-computed name. This messes a bit with our
    > error messages, so we re-use the CallPrinter to also find destructuring
    > assignment based errors, and fiddle with the error message there. As
    > a side-effect, we also get out the object name in the AST, so we can
    > output a slightly nicer error message.
    > 
    > Change-Id: Iafa858e27ed771a146cd3ba57903cc73bb46951d
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1773254
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63453}
    
    TBR=leszeks@chromium.org,verwaest@chromium.org
    
    Change-Id: I74cf06ebd987e5b8bbe1831b0042c085edf37f5b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776994Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63465}
    28fa4cb4
destructuring-undefined-string-property.out 211 Bytes