• Deepti Gandluri's avatar
    Revert "Allow lookup of matching scripts in Isolate compilation cache" · a13598ae
    Deepti Gandluri authored
    This reverts commit c443858f.
    
    Reason for revert: Several UBSan failures: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/21547/overview
    
    Original change's description:
    > Allow lookup of matching scripts in Isolate compilation cache
    >
    > Currently, if the same script text is compiled multiple times with
    > differing details (such as name, line number, or host-defined options),
    > then multiple copies of that script are added to the Isolate's
    > compilation cache. However, any attempt to look up those scripts can
    > find only the first instance. This change makes the script compilation
    > cache behave more consistently by checking the details while searching
    > the hash table for a match, rather than after a potential match has been
    > found.
    >
    > Bug: v8:12808
    > Change-Id: Ic9da0bf74f359d4f1c88af89d585404f173056ee
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3671615
    > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/main@{#80919}
    
    Bug: v8:12808
    Change-Id: I6d007374fb607a2670ca260c6bd0d6774d7f51d7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687311
    Auto-Submit: Deepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#80922}
    a13598ae
test-serialize.cc 180 KB