• Jakob Gruber's avatar
    [nci] Modify Construct node layouts · 796fdcd0
    Jakob Gruber authored
    Prior to this CL, the construct node layout was:
    
     {target, args..., new_target}
    
    The new layout is:
    
     {target, new_target, args..., feedback_vector}
    
    Having new_target at index 1 brings it closer to call node layout,
    which is now identical except that it has receiver at index 1. The new
    feedback vector input will be needed for NCI code.
    
    Affected node kinds are:
    
    - JSConstruct
    - JSConstructWithArrayLike
    - JSConstructWithSpread
    - JSConstructForwardVarargs (just the new_target position change)
    
    Bug: v8:8888
    Change-Id: I4c68a0901d01e8862fd276c8a858799d5f4ff024
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278475
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68692}
    796fdcd0
js-generic-lowering.cc 50.7 KB