• ahaas's avatar
    x87: fix the use of CheckFloatEq and CheckDoubleEq in test. · a5d41888
    ahaas authored
    Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced
    a macro which first stores the expected result in a volatile variable.
    
    Here are some comments of previous CLs:
    
    The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/.
    
      Here is the key comments from CL #31808
      Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function,
      those inlined functions has different behavior comparing with GCC ia32 build and x87 build.
      The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value.
      The V8 turbofan JITTed has exactly same result in both X87 and IA32 port.
    
      So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i).
    
    R=titzer@chromium.org, weiliang.lin@intel.com
    
    Review URL: https://codereview.chromium.org/1773513002
    
    Cr-Commit-Position: refs/heads/master@{#34534}
    a5d41888
codegen-tester.cc 25.2 KB