• Igor Sheludko's avatar
    Revert "Reland "Create a fast path to get migration target when updating map"" · 1898944b
    Igor Sheludko authored
    This reverts commit 6ec90ece.
    
    Reason for revert: causes a lot of Canary crashes (chromium:895208).
    GC relies on an the fact that the transition array stays alive while it's owner map
    is alive (this is needed in order to properly transfer descriptor array ownership
    to the parent map when the map owning a shared descriptor array dies). We need to
    rethink a way of caching the migration target shortcut.
    
    Original change's description:
    > Reland "Create a fast path to get migration target when updating map"
    >
    > This is a reland of c285380c
    >
    > Original change's description:
    > > Create a fast path to get migration target when updating map
    > >
    > > During map updating, store the pointer to new map in the
    > > raw_transitions slot of the old map that is deprecated from map
    > > transition tree. Thus, we can get the migration target directly
    > > instead of TryReplayPropertyTransitions when updating map.
    > >
    > > This can improve Speedometer2.0 Elm-TodoMVC case by ~5% on ATOM
    > > Chromebook and ~9% on big-core Ubuntu.
    > >
    > > Change-Id: I56f9ce5183bbdd567b964890f623ef0ceed9b7db
    > > Reviewed-on: https://chromium-review.googlesource.com/1233433
    > > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
    > > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#56303}
    >
    > Change-Id: Idf0b7716b92a6a15bfe58721c2c34dbd02b31137
    > Reviewed-on: https://chromium-review.googlesource.com/c/1270261
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
    > Cr-Commit-Position: refs/heads/master@{#56588}
    
    TBR=ishell@chromium.org,shiyu.zhang@intel.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: Ie7e9b98395b041a1095da549d1cd71d7180a4888
    Bug: chromium:895208
    Reviewed-on: https://chromium-review.googlesource.com/c/1280223
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56641}
    1898944b
test-field-type-tracking.cc 106 KB