• Josh Wolfe's avatar
    [api] remove --harmony-function-tostring behavior from CompileFunctionInContext · aeb8f332
    Josh Wolfe authored
    The ')'-in-parameter checking is not necessary for
    CompileFunctionInContext. The arguments array is expected to be an
    array of identifiers, not an array of arbitrary strings that get
    concatenated.
    
    Furthermore, there's no reason to have the .toString() representation
    look like it came from CreateDynamicFunction(), and in fact inserting
    line breaks makes it more complicated to map line and column numbers
    correctly.
    
    Overall, the --harmony-function-tostring behavior only makes
    CompileFunctionInContext worse, so this CL removes it.
    
    R=littledan@chromium.org, adamk@chromium.org, caitp@igalia.com
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
    
    Bug: v8:4958
    Change-Id: Ifbc8a83216ca6a6979da1199972aa65f4bee36c3
    Reviewed-on: https://chromium-review.googlesource.com/558220Reviewed-by: 's avatarDaniel Ehrenberg <littledan@chromium.org>
    Commit-Queue: Josh Wolfe <jwolfe@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#46456}
    aeb8f332
test-compiler.cc 26.1 KB